e2e: fix e2e test for the sriovnetworknodepolicy #742
Conversation
We have to verify only the VF range we have specified. If not we will expect VFs to have certain values that have not been synced by the controller.
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
|
/test-e2e-nvidia-all |
Pull Request Test Coverage Report for Build 10010164013Details
💛 - Coveralls |
|
Nvidia e2e test CI failed. /test-e2e-nvidia-all |
|
Hi @tobiasgiese any plans to run the conformance tests on NVIDIA CI? that suite contain much more tests and validations |
You mean the tests from /test-nvidia-e2e-all? They run successfully already |
|
I mean running this suite https://github.com/k8snetworkplumbingwg/sriov-network-operator/tree/master/test/conformance @tobiasgiese |
|
@SchSeba the conformance tests will run with the sriov-network-operator/.github/workflows/test.yml Lines 156 to 157 in 588abb4 the task |
|
yep I know I create that job :P the problem is that it runs on virtual hardware (qemu virtual IGB driver) that is why I wanted to ask if NVIDIA can run that on MLX cards it will help us cover the mlx plugin code in CI |
|
cc @tobiasgiese |
Okay, now I got you :) |
The current Nvidia e2e tests are failing. To resolve this issue, we need to verify only the specified VF range. Without this change, we are mistakenly expecting VFs to have certain values that have not been synchronized by the controller.